Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34807 )
Change subject: intel/haswell: Move platform_enter_postcar() ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/34807/1/src/cpu/intel/haswell/romst... File src/cpu/intel/haswell/romstage.c:
https://review.coreboot.org/c/coreboot/+/34807/1/src/cpu/intel/haswell/romst... PS1, Line 16: #include <stdint.h> : #include <console/console.h> : #include <arch/cpu.h> : #include <cf9_reset.h> : #include <cpu/x86/bist.h> : #include <cpu/x86/msr.h> : #include <cpu/x86/mtrr.h> : #include <timestamp.h> : #include <device/pci_def.h> : #include <cpu/x86/lapic.h> : #include <cbmem.h> : #include <commonlib/helpers.h> : #include <program_loading.h> : #include <romstage_handoff.h> : #include <vendorcode/google/chromeos/chromeos.h> : #if CONFIG(EC_GOOGLE_CHROMEEC) : #include <ec/google/chromeec/ec.h> : #endif : #include <northbridge/intel/haswell/haswell.h> : #include <northbridge/intel/haswell/raminit.h> : #include <southbridge/intel/lynxpoint/pch.h> : #include <southbridge/intel/lynxpoint/me.h> : #include <cpu/intel/romstage.h> : #include "haswell.h" It looks like this leaves us with more #includes than statements in the code (I didn't count). Please remove at least those that were only used by platform_enter_postcar(). I wouldn't mind to drop some more, though (stdint? msr? pci? chromeos?).