Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36068 )
Change subject: automation: update script and template files for new variant
......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36068/5/util/mainboard/google/hatch...
File util/mainboard/google/hatch/template/gpio.c:
https://review.coreboot.org/c/coreboot/+/36068/5/util/mainboard/google/hatch...
PS5, Line 24: override_gpio_table
This is already provided as a weak function in baseboard/gpio. […]
Done
https://review.coreboot.org/c/coreboot/+/36068/5/util/mainboard/google/hatch...
PS5, Line 40: variant_early_gpio_table
I think we should just provide a weak implementation of this in baseboard/hatch. […]
Done
https://review.coreboot.org/c/coreboot/+/36068/5/util/mainboard/google/hatch...
File util/mainboard/google/hatch/template/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/36068/5/util/mainboard/google/hatch...
PS5, Line 21: #define GPIO_MEM_CONFIG_0 GPP_F20
It would be worthwhile moving this to baseboard/gpio.h. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36068
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie946cfd7c071824168faa38fd53bd338a5a451e1
Gerrit-Change-Number: 36068
Gerrit-PatchSet: 6
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Scott Collyer
scollyer@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 28 Oct 2019 17:17:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Comment-In-Reply-To: Justin TerAvest
teravest@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment