Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37111 )
Change subject: util/ifdtool: Add Jasperlake platform support under IFDv2
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37111/5/util/ifdtool/ifdtool.c
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/37111/5/util/ifdtool/ifdtool.c@1641
PS5, Line 1641: } else if (!strcmp(optarg, "jsl")) {
: platform = PLATFORM_JSL;
The original idea of adding this argument was to ensure ifdtool can group platforms with same IFD ve […]
The only significant difference I can see between APL and GLK descriptors is that FLMAP1[24..31] went from 0x13 on APL to 0x17 on GLK, and that half of FLCOMP was redefined, since the EC is now a possible master, which has its own FLMSTR5 register at FMBA + 0x10.
w.r.t. the SPI controller, I just made GLK work using the same code as APL, so its hardware must be the same.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37111
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4963ab249a8e0b31c014e92edf1e0a4a4f638084
Gerrit-Change-Number: 37111
Gerrit-PatchSet: 5
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 30 Mar 2020 23:29:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment