Cheng-Yi Chiang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36029 )
Change subject: drivers/i2c/rt1011: Add a driver for RT1011 ......................................................................
Patch Set 11:
(2 comments)
Patch Set 9: Code-Review+1
(1 comment)
Thank you for the detailed explanation. I guess, ACPI is reality, but I still think, the OS driver should read it directly.
Hi Paul, Thanks for the understanding. I would really hope to merge this soon as project has its timeline. But I would still like to learn more about your concern. Are you generally against the idea of setting device property through coreboot ? Or is it because the information is from reading VPD? I am wondering because we have seen other cases of device driver in coreboot preparing _DSD, and other driver in coreboot reading VPD. So combining these steps to prepare device property from VPD seems to be a natural solution to me. Thanks!
https://review.coreboot.org/c/coreboot/+/36029/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36029/9//COMMIT_MSG@11 PS9, Line 11: Management(DSM)
Please add a space before the (.
Done
https://review.coreboot.org/c/coreboot/+/36029/9/src/drivers/i2c/rt1011/rt10... File src/drivers/i2c/rt1011/rt1011.c:
https://review.coreboot.org/c/coreboot/+/36029/9/src/drivers/i2c/rt1011/rt10... PS9, Line 95: name[4] = '\0';
nit: this isn't strictly necessary, snprintf will write a 0 to the end of the string/buffer, whichev […]
Done