Attention is currently required from: Hung-Te Lin, Bayi Cheng, Rex-BC Chen, Yidi Lin, Yu-Ping Wu.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68659 )
Change subject: soc/mediatek/mt8186: Lower SPI NOR frequency from 52Mhz to 39Mhz
......................................................................
Patch Set 3: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68659/comment/15252201_fab44c42
PS3, Line 10: Mhz
nit: capitalize the 'h'? `MHz`
https://review.coreboot.org/c/coreboot/+/68659/comment/4fe7750e_a6b45e02
PS3, Line 11: 52Mhz to 39 Mhz
nit: Same as above. Also, let's be consistent with (not) having space before `MHz` 😄
https://review.coreboot.org/c/coreboot/+/68659/comment/1bcf0a23_d0bba436
PS3, Line 17: BRAHCH
typo: BRA*N*CH
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68659
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibcf4549fefa28b2ad9c38e31ec9a69f8afeff3fd
Gerrit-Change-Number: 68659
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bayi Cheng
bayi.cheng@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Bayi Cheng
bayi.cheng@mediatek.corp-partner.google.com
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 21 Oct 2022 11:40:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment