21 Dec
2018
21 Dec
'18
4:57 a.m.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30281 )
Change subject: mb/google/hatch: Add EC trigger events and acpi configs ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h:
https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/... PS7, Line 79: #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */
Ok, I have created bug 121306806 to track it
we can add the required changes in this CL itself and call it out in commit msg
https://review.coreboot.org/#/c/coreboot/+/26970/
--
To view, visit https://review.coreboot.org/c/coreboot/+/30281
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a86f609c269cb59e546fc7ba4ba032e5ea8341a
Gerrit-Change-Number: 30281
Gerrit-PatchSet: 7
Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 21 Dec 2018 04:57:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aamir Bohra aamir.bohra@intel.com
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment