Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25634 )
Change subject: soc/intel/common: Implement EFI_MP_SERVICES_PPI structure APIs
......................................................................
Patch Set 47:
@Subrata @Nate yes the U-Boot integration looks better. BTW we are
also not using camelcase names for functions are variables in our
code
@Philipp: Do you mean below camel casing? i don;t think we have any other camel case apart from below structure due to EFI structure requirement.
static EFI_PEI_MP_SERVICES_PPI mp_service_ppi = {
.GetNumberOfProcessors = mp_get_number_of_processors,
.GetProcessorInfo = mp_get_processor_info,
.StartupAllAPs = mp_startup_all_aps,
.StartupThisAP = mp_startup_this_ap,
.SwitchBSP = mp_switch_bsp,
.EnableDisableAP = mp_enable_disable_ap,
.WhoAmI = mp_identify_processor,
};
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25634
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie844e3f15f759ea09a8f3fd24825ee740151c956
Gerrit-Change-Number: 25634
Gerrit-PatchSet: 47
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Vincent Zimmer
vincent.zimmer@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: dhaval v sharma
dhaval.v.sharma@intel.com
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Comment-Date: Wed, 20 Feb 2019 10:29:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment