Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46389 )
Change subject: mediatek/mt8192: add spmfw loader
......................................................................
Patch Set 18:
(2 comments)
move last review from CB:47287
https://review.coreboot.org/c/coreboot/+/46389/18/src/soc/mediatek/mt8192/sp...
File src/soc/mediatek/mt8192/spm.c:
https://review.coreboot.org/c/coreboot/+/46389/18/src/soc/mediatek/mt8192/sp...
PS18, Line 12: #define SPMFW_HEADER_SIZE (16)
Yu-Ping Wu
Nov 11
No need for the parentheses.
https://review.coreboot.org/c/coreboot/+/46389/18/src/soc/mediatek/mt8192/sp...
PS18, Line 583: offset += SPMFW_HEADER_SIZE; /* binary start offset */
Yu-Ping Wu
Nov 11
If this number is a constant, should we write
offset = SPMFW_HEADER_SIZE
instead?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46389
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6478b98f426d2f3e0ee919d37d21d909ae8a6371
Gerrit-Change-Number: 46389
Gerrit-PatchSet: 18
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Roger Lu
roger.lu@mediatek.com
Gerrit-Reviewer: Roger Lu
roger.lu@mediatek.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Nicolas Boichat
drinkcat@chromium.org
Gerrit-CC: Nicolas Boichat
drinkcat@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 12 Nov 2020 09:56:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
