[coreboot-gerrit] [M] Change in coreboot[main]: soc/mediatek/mt8196: Add MMinfra driver support

[Yidi Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu.

Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85188?usp=email )

Change subject: soc/mediatek/mt8196: Add MMinfra driver support
......................................................................

Patch Set 23:

(8 comments)

File src/soc/mediatek/mt8196/mminfra.c:

https://review.coreboot.org/c/coreboot/+/85188/comment/7548ed16_dcf80456?usp... :
PS23, Line 15: (u32 addr, u32 val)
static void wait_for_write_done(u32 write_reg, u32 status_reg, u32 val)

https://review.coreboot.org/c/coreboot/+/85188/comment/3d8d27f9_c78876bc?usp... :
PS23, Line 17: 	write32p(addr,val);
> `space required after that ',' (ctx:VxV)`

Please fix.

https://review.coreboot.org/c/coreboot/+/85188/comment/fe0d7e7c_7e005293?usp... :
PS23, Line 18: 	if (!wait_us(TIMEOUT_US, read32p(addr)==val))
> `spaces required around that '==' (ctx:VxV)`

Please fix.

https://review.coreboot.org/c/coreboot/+/85188/comment/e938c340_c6a8fc68?usp... :
PS23, Line 19: 		die("Wait write done timeout \n");
> `unnecessary whitespace before a quoted newline`

Please fix.

https://review.coreboot.org/c/coreboot/+/85188/comment/3a3ebfda_856a522d?usp... :
PS23, Line 38: read32p(MMINFRA_MM0_GALS_PROT_TX_RDY),
just pass the address to `wait_for_write_done`.

https://review.coreboot.org/c/coreboot/+/85188/comment/7611de2f_4845b236?usp... :
PS23, Line 37: write32p(MMINFRA_MM0_GALS_PROT_TX_EN, 0xff);
             : 	wait_for_write_done(read32p(MMINFRA_MM0_GALS_PROT_TX_RDY), 0xff);
just call wait_for_write_done

https://review.coreboot.org/c/coreboot/+/85188/comment/6a1c8c59_40b78780?usp... :
PS23, Line 40: EN
RDY

https://review.coreboot.org/c/coreboot/+/85188/comment/2ab0e14a_6f3b3b0a?usp... :
PS23, Line 53: EN
RDY