Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36094 )
Change subject: mb/siemens/mc_apl{3,5}: Remove __weak symbol from GPIO functions ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36094/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36094/1//COMMIT_MSG@13 PS1, Line 13: might choose the tables from the baseboard.
Was this the case here, or is it just for correctness sake?
It was the case for mc_apl3 and mc_apl5.
https://review.coreboot.org/c/coreboot/+/36094/1//COMMIT_MSG@14 PS1, Line 14: This patch removes the __weak definition making these functions
Please add a blank line between paragraphs.
Will do.