Attention is currently required from: Hung-Te Lin, Paul Menzel, Rex-BC Chen, Yu-Ping Wu. Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63251 )
Change subject: coreboot tables: Add PCIe info to coreboot table ......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63251/comment/c0d45d5b_8251b5e8 PS5, Line 9: Add PCIe info to coreboot table.
As this is kind of a new “API”, please elaborate, why this information is needed now – and hasn’t on […]
Done
File payloads/libpayload/include/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/63251/comment/a0f91614_572eb99e PS4, Line 275: uint32_t
Use uint64_t for address?
Done
File payloads/libpayload/include/sysinfo.h:
https://review.coreboot.org/c/coreboot/+/63251/comment/d471b3ad_e6944033 PS4, Line 87: struct {
Can we use the cb_pcie struct (just like the 'framebuffer' field below)? Then cb_parse_pcie() could […]
Done, I use memcpy to fill the structure, I'm not sure which one is better, any suggestions?