Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44259 )
Change subject: arch/x86: Select HAVE_ASAN_IN_RAMSTAGE
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44259/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44259/1//COMMIT_MSG@9
PS1, Line 9: Enable ASan in ramstage for all x86 platforms.
This sounds like for x86 ASan in ramstage is enabled and active per default which is not the case.
Please add here that in order to activate ASan in ramstage the right Kconfig switch needs to be enabled in menuconfig.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44259
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5b3dc18368a5da6bdc70c84527b95d1688dc19f
Gerrit-Change-Number: 44259
Gerrit-PatchSet: 1
Gerrit-Owner: Harshit Sharma
harshitsharmajs@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Aug 2020 16:28:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment