Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47483 )
Change subject: [WIP] soc/amd/common: factor out SMU code from Picasso
......................................................................
Patch Set 2:
Is it valuable to further separate common/block/smu support into the supported generations then have soc/<name> select the right one? (Not that I'm anticipating being able to open source much SMU code soon, but would like to plan for it.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47483
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibaf5b91ab35428e4c771e7163c6e0c4fc50371e7
Gerrit-Change-Number: 47483
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Nov 2020 17:32:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment