Attention is currently required from: Hung-Te Lin, Paul Menzel, Ruihai Zhou, Xuxin Xiong, Yang Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81584?usp=email )
Change subject: mb/google/corsola: Add new board variant Wugtrio ......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7: https://qa.coreboot.org/job/coreboot-gerrit/255042/consoleText ``` aarch64-elf-ld.bfd: warning: /cb-build/coreboot-gerrit.0/gcc/GOOGLE_WUGTRIO/cbfs/fallback/ramstage.debug has a LOAD segment with RWX permissions aarch64-elf-ld.bfd: /cb-build/coreboot-gerrit.0/gcc/GOOGLE_WUGTRIO/ramstage/mainboard/google/corsola/panel.o: in function `get_active_panel': /home/coreboot/node-root/workspace/coreboot-gerrit/src/mainboard/google/corsola/panel.c:53:(.text.get_active_panel+0x0): undefined reference to `get_panel_description' /home/coreboot/node-root/workspace/coreboot-gerrit/src/mainboard/google/corsola/panel.c:53:(.text.get_active_panel+0x0): relocation truncated to fit: R_AARCH64_JUMP26 against undefined symbol `get_panel_description' make[2]: *** [src/arch/arm64/Makefile.mk:136: /cb-build/coreboot-gerrit.0/gcc/GOOGLE_WUGTRIO/cbfs/fallback/ramstage.debug] Error 1 ```
The panel.c logic forces the variant that uses MIPI panel implementing `get_panel_description` at the board creation. I would suggest reordering the panel configuration patch and squashing CB:81585 into this patch.
The patch order will be ``` mb/google/corsola: Add new board variant Wugtrio mb/google/corsola: Move MIPI panel to BOARD_SPECIFIC_OPTIONS section drivers/mipi: Add support for KD_KD101NE3_40TI panel ```