Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39327 )
Change subject: cbfs: Move more stuff into cbfs_boot_lookup()
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39327/3/src/lib/cbfs.c
File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/39327/3/src/lib/cbfs.c@62
PS3, Line 62: const struct region_device *bootdev = boot_device_ro();
I'm using the assumption here that boot_device_ro() is always the root rdev for anything cbfs_get_bo […]
It does help some. I think that instead of calling boot_device_ro() here you can do the following as it's the exact semantic you desire.
bootdev = rdev_root(&fh->data);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39327
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4bc9b7cbc42a4211d806a3e3389abab7f589a25a
Gerrit-Change-Number: 39327
Gerrit-PatchSet: 6
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Oct 2020 22:39:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment