Attention is currently required from: Kane Chen, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60401 )
Change subject: soc/intel/alderlake: Check clkreq overlap
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/60401/comment/088e862b_7d1d7ffa
PS5, Line 51: static
Hold on, we don't want this to be a static variable, otherwise it will keep its value between the two calls to it (once for PCH RP, once for CPU RP). Just remove the static and I think this will work
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60401
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f701a19118f4702c227b17e43b6551591d9b344
Gerrit-Change-Number: 60401
Gerrit-PatchSet: 5
Gerrit-Owner: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 04 Jan 2022 15:35:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment