Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31329 )
Change subject: vboot: copy data structures to CBMEM for downstream use ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/#/c/31329/8/src/security/vboot/common.c File src/security/vboot/common.c:
https://review.coreboot.org/#/c/31329/8/src/security/vboot/common.c@152 PS8, Line 152: vb2_working_data_size
Sure, but this function doesn't have access to vb2_context (that's stored in verstage_main). […]
I think the solution here was to store workbuf_used (just that, not the whole context) in struct vb2_working_data. You'll also need that later when you pass vb2_working_data to depthcharge and try to recreate the workbuffer there (unless you wanna copy around the whole 12KB there again, I guess...).
https://review.coreboot.org/#/c/31329/9/src/soc/intel/skylake/Kconfig File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/#/c/31329/9/src/soc/intel/skylake/Kconfig@110 PS9, Line 110: select VBOOT_STARTS_IN_ROMSTAGE I don't think you want to commit this?