Attention is currently required from: Felix Singer, Jérémy Compostella, yuchi.chen@intel.com.
Shuo Liu has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/83320?usp=email )
Change subject: soc/intel/common/block/imc: Add Integrated Memory Controller driver
......................................................................
Patch Set 15:
(2 comments)
File src/soc/intel/common/block/smbus/smbuslib.c:
https://review.coreboot.org/c/coreboot/+/83320/comment/914d690e_2d951411?usp... :
PS15, Line 70: if (i2c_eeprom_read(addr, 0, SPD_PAGE_LEN, spd) < 0) {
if (!IMC && ...) and comment that IMC doesn't support i2c eeprom
File src/southbridge/intel/common/smbus.c:
https://review.coreboot.org/c/coreboot/+/83320/comment/195c1dd1_cc7bbfa8?usp... :
PS15, Line 465: if (CONFIG(SOUTHBRIDGE_INTEL_I82371EB) || CONFIG(SOUTHBRIDGE_INTEL_I82801DX) ||
this is for pch smbus and we should not change here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83320?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3f47ddeda94d3882852d64c0052f8fb42b6b7ad2
Gerrit-Change-Number: 83320
Gerrit-PatchSet: 15
Gerrit-Owner: yuchi.chen@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Vasiliy Khoruzhick
vasilykh@arista.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: yuchi.chen@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Fri, 30 Aug 2024 08:31:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No