Attention is currently required from: Amanda Huang, Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Rishika Raj.
Subrata Banik has posted comments on this change by Rishika Raj. ( https://review.coreboot.org/c/coreboot/+/83549?usp=email )
Change subject: mainboard/google/brya/variants/orisa: Change board strap memory config
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83549/comment/842a485c_ff9a7e14?usp... :
PS1, Line 7: mainboard
mb
https://review.coreboot.org/c/coreboot/+/83549/comment/c69829f9_9c7042b5?usp... :
PS1, Line 17: None
There should be atleast build test.
File src/mainboard/google/brya/variants/orisa/memory.c:
https://review.coreboot.org/c/coreboot/+/83549/comment/80b950da_076922f9?usp... :
PS1, Line 90: NC
this is not needed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83549?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4e979686833095a904b114500dc1142def583afa
Gerrit-Change-Number: 83549
Gerrit-PatchSet: 1
Gerrit-Owner: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Amanda Huang
jadequeen0820@gmail.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Amanda Huang
jadequeen0820@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 18 Jul 2024 18:04:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No