Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36143 )
Change subject: arch/x86/boot.c: Pass arguments when running programs ......................................................................
Patch Set 10:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36143/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36143/2//COMMIT_MSG@9 PS2, Line 9: Payloads can use coreboot tables passed on the stack.
Correct. Calling through a function pointer is subject to the ABI the compiler is targeting.
Done
https://review.coreboot.org/c/coreboot/+/36143/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36143/8//COMMIT_MSG@12 PS8, Line 12: The assumption is made that stages and payloads start in assembly : where stack alignment does not matter.
Well actually this assumption does not have to be made I think.
Done
https://review.coreboot.org/c/coreboot/+/36143/2/src/arch/x86/boot.c File src/arch/x86/boot.c:
https://review.coreboot.org/c/coreboot/+/36143/2/src/arch/x86/boot.c@33 PS2, Line 33: doit
You should decorate this w/ asmlinkage to ensure the i386 ABI is used in case compiler flags are fli […]
Done
https://review.coreboot.org/c/coreboot/+/36143/3/src/arch/x86/boot.c File src/arch/x86/boot.c:
https://review.coreboot.org/c/coreboot/+/36143/3/src/arch/x86/boot.c@34 PS3, Line 34: asmlinkage
I requested this thinking about x86-32. […]
Done