Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32017 )
Change subject: mb/google/hatch: Enable FP MCU
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32017/3/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/32017/3/src/mainboard/google/hatch/variants/...
PS3, Line 38: .gspi[1] = {
: .speed_mhz = 1,
: .early_init = 1,
: },
Why is this required? We don't talk to the FP device in firmware.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32017
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2eba205d5e63664dca684fbd849454c5a2fe0d0e
Gerrit-Change-Number: 32017
Gerrit-PatchSet: 3
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nicolas Norvez
norvez@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 21 Mar 2019 22:10:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment