Attention is currently required from: ChiaLing, Sumeet R Pawnikar, Zhuohao Lee.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75681?usp=email )
Change subject: mb/google/dedede/var/dibbi: Update power limits ......................................................................
Patch Set 9:
(2 comments)
File src/mainboard/google/dedede/variants/dibbi/ramstage.c:
https://review.coreboot.org/c/coreboot/+/75681/comment/2e5757f2_ca65ea39 : PS9, Line 16: 6000 In devicetree this is set to 3000. Did you mean to change it here? But also I think we can just delete this as I suggested below.
https://review.coreboot.org/c/coreboot/+/75681/comment/6de66a8c_dcd78a11 : PS9, Line 66: variant_update_cpu_power_limits(pwr_limits, total_entries); Did you test this? It's not working for me because the common code uses `DEV_PTR(dptf_policy)` which doesn't work on the firmware branch. We might be able to backport support for it, but I haven't tried yet.
But actually I think we can just get rid of this. It's for setting different DPTF limits based on CPU SKU, but we don't need this on dibbi since we're only using 6W SKUs and we want the same limits for all. If OEM devices want to set different limits they can add this later, but I think it's unlikely they will.