[coreboot-gerrit] Change in coreboot[master]: apollolake mainboards: Set PMC as hidden in devicetree

[Subrata Banik (Code Review)]

Attention is currently required from: Felix Singer, Nico Huber, Maxim Polyakov, Tim Wawrzynczak, Angel Pons, Michael Niewöhner.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62138 )

Change subject: apollolake mainboards: Set PMC as hidden in devicetree
......................................................................

Patch Set 3:

(1 comment)

Patchset:

PS3:
> > > Looks like the usual difference between APL/GLK and PCH platforms.
> >
> > Yup. Looking for suggestion, if a __weak implementation can be allowed here to land `pmc_clear_pmcon_sts()` in common for have overrides in APL SoC alone.
>
> What I mean is that the common implementation should be put into `src/soc/intel/common/pch/`, then we wouldn't need a weak symbol.

Just having pmc_clear_pmcon_sts() function alone into `src/soc/intel/common/pch/` won't make any sense. Also, moving the `pmc` block code into `src/soc/intel/common/pch/` is not scalable as APL/GLK/DNV also using this common PMC block.

WDYT? _weak implementation for pmc_clear_pmcon_sts() is the easiest option here ?