Attention is currently required from: Andrey Petrov, Damien Zammit, Felix Held, Huang Jin, Julius Werner, Lee Leahy, Matt DeVillier, Ronak Kanabar.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52933?usp=email )
Change subject: lib/romstage_handoff.c: Initialize using a cbmem hook
......................................................................
Patch Set 3:
(1 comment)
File src/lib/romstage_handoff.c:
https://review.coreboot.org/c/coreboot/+/52933/comment/d6b53986_c50c78e7 :
PS3, Line 56: ROMSTAGE_CBMEM_INIT_HOOK(romstage_handoff_init);
Since this file is compiled unconditionally, adding an INIT_HOOK() expands this to a lot of platforms which never used it. Please add a Kconfig to limit compilation of the file to the right set of boards if you want to do this (I'm not quite sure what exactly this is or what the right set of boards for it would be, but I know the Arm boards I work on don't use this, for example).
Done. HAVE_ACPI_RESUME is the proper flag.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52933?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I93abf33a6eb055eeaba1fed5042387822de1aa20
Gerrit-Change-Number: 52933
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Huang Jin
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
rudolphpatrick05@gmail.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Huang Jin
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 02 Feb 2024 10:19:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment