Attention is currently required from: Kyösti Mälkki. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59000 )
Change subject: mb/google,intel: Add ChromeOS GPIOs to onboard.h ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
File src/mainboard/google/butterfly/chromeos.c:
https://review.coreboot.org/c/coreboot/+/59000/comment/bc7a211b_90a1726e PS4, Line 16: #define DEVMODE_GPIO 54 DEVMODE_GPIO is unused
File src/mainboard/google/stout/chromeos.c:
https://review.coreboot.org/c/coreboot/+/59000/comment/439de42f_6a8643c3 PS4, Line 79: CROS_GPIO_REC_AH(CROS_GPIO_VIRTUAL, CROS_GPIO_DEVICE_NAME), Does deduplicating this have any side-effects? At least I'd mention this change in the commit message.
File src/mainboard/intel/strago/chromeos.c:
https://review.coreboot.org/c/coreboot/+/59000/comment/de618976_e8491b8f PS4, Line 11: #define ACTIVE_LOW 0 : #define ACTIVE_HIGH 1 Already defined in <commonlib/coreboot_tables.h>, included through <boot/coreboot_tables.h>