Attention is currently required from: Martin Roth, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68572 )
Change subject: include/cpu/msr.h: transform into an union
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
File src/include/cpu/x86/msr_access.h:
https://review.coreboot.org/c/coreboot/+/68572/comment/2d66d491_093917ce
PS3, Line 10: struct {
: unsigned int lo;
: unsigned int hi;
: };
: uint64_t raw;
lol, touche!
Don't worry, had the same question over here before remembering the portability of MSRs 😄
File src/soc/intel/common/block/sgx/sgx.c:
https://review.coreboot.org/c/coreboot/+/68572/comment/3f23409c_08fd0077
PS3, Line 81: if ((prmrr_base.hi == 0) && (prmrr_base.lo == 0)
A bunch of these could be cleaned up in follow-ups.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68572
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b026cd3807fd68d805051a74b3d31fcde1c5626
Gerrit-Change-Number: 68572
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 11 Nov 2022 11:57:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment