Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43078 )
Change subject: mb/google/zork: Revert Don't expose reset GPIO for touchscreen to OS
......................................................................
Patch Set 2:
(1 comment)
Updated the commit message as well since it's only a partial revert.
https://review.coreboot.org/c/coreboot/+/43078/1/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/berknip/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43078/1/src/mainboard/google/zork/v...
PS1, Line 71: 32 + 20
Should we keep the delay as is?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43078
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57a070d94f961cec43834c8bedd5dafc8a54171a
Gerrit-Change-Number: 43078
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Comment-Date: Fri, 07 Aug 2020 21:21:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment