Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Angel Pons.
Boris Mittelberg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56840 )
Change subject: mb/google/dedede: allow MKBP devices and disable TBMC device
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h:
https://review.coreboot.org/c/coreboot/+/56840/comment/b62f957e_6e6b8714
PS5, Line 73: EC_ENABLE_TBMC_DEVICE
EC sets the button/switch related bit in MKBP event information and the kernel driver translates tha […]
Good catch. I rebuilt locally and re-tested without TBMC
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56840
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d1f43e4dd56318af4c1d5f5c1c3a2c237a05c5f
Gerrit-Change-Number: 56840
Gerrit-PatchSet: 6
Gerrit-Owner: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Aseda Aboagye
aaboagye@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 11 Aug 2021 18:06:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment