HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43968 )
Change subject: src/drivers: Add missing <{stddef,stdint}.h> ......................................................................
Patch Set 2:
(47 comments)
I've added comments to highlight why stdint or/and stddef are needed. this to make the review easier. Thx
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/amd/agesa/state... File src/drivers/amd/agesa/state_machine.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/amd/agesa/state... PS2, Line 32: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/aspeed/common/a... File src/drivers/aspeed/common/aspeed_coreboot.h:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/aspeed/common/a... PS2, Line 49: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/crb/tis.c File src/drivers/crb/tis.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/crb/tis.c@17 PS2, Line 17: uint16_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/crb/tis.c@85 PS2, Line 85: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/crb/tpm.h File src/drivers/crb/tpm.h:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/crb/tpm.h@60 PS2, Line 60: uint16_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/crb/tpm.h@68 PS2, Line 68: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/crb/tpm.c File src/drivers/crb/tpm.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/crb/tpm.c@28 PS2, Line 28: uint32_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/crb/tpm.c@200 PS2, Line 200: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/generic/cbfs-se... File src/drivers/generic/cbfs-serial/cbfs-serial.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/generic/cbfs-se... PS2, Line 22: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/gfx/generic/gen... File src/drivers/gfx/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/gfx/generic/gen... PS2, Line 105: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/i2c/designware/... File src/drivers/i2c/designware/dw_i2c.h:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/i2c/designware/... PS2, Line 124: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/i2c/designware/... File src/drivers/i2c/designware/dw_i2c.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/i2c/designware/... PS2, Line 40: uint32_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/i2c/designware/... PS2, Line 230: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/i2c/tpm/tis.c File src/drivers/i2c/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/i2c/tpm/tis.c@5... PS2, Line 59: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/i2c/tpm/tpm.h File src/drivers/i2c/tpm/tpm.h:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/i2c/tpm/tpm.h@4... PS2, Line 47: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp1_1/fs... File src/drivers/intel/fsp1_1/fsp_relocate.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp1_1/fs... PS2, Line 14: ssize_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp1_1/fs... PS2, Line 36: uint8_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp1_1/mm... File src/drivers/intel/fsp1_1/mma_core.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp1_1/mm... PS2, Line 12: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp1_1/vb... File src/drivers/intel/fsp1_1/vbt.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp1_1/vb... PS2, Line 13: uint8_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp1_1/vb... PS2, Line 16: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/de... File src/drivers/intel/fsp2_0/debug.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/de... PS2, Line 10: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/de... PS2, Line 10: uint8_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/ho... File src/drivers/intel/fsp2_0/hob_display.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/ho... PS2, Line 9: uint16_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/ho... PS2, Line 121: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/in... File src/drivers/intel/fsp2_0/include/fsp/debug.h:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/in... PS2, Line 14: uint32_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/in... PS2, Line 44: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/mm... File src/drivers/intel/fsp2_0/mma_core.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/mm... PS2, Line 9: uint8_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/mm... PS2, Line 13: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/up... File src/drivers/intel/fsp2_0/upd_display.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/up... PS2, Line 9: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/fsp2_0/up... PS2, Line 10: uint64_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/gma/acpi.... File src/drivers/intel/gma/acpi.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/gma/acpi.... PS2, Line 12: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/gma/vbt.c File src/drivers/intel/gma/vbt.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/gma/vbt.c... PS2, Line 14: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/intel/gma/vbt.c... PS2, Line 18: u8 stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/pc80/tpm/tis.c File src/drivers/pc80/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/pc80/tpm/tis.c@... PS2, Line 100: u16 stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/pc80/tpm/tis.c@... PS2, Line 534: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/secunet/dmi/smb... File src/drivers/secunet/dmi/smbios.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/secunet/dmi/smb... PS2, Line 30: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/bitbang.c File src/drivers/spi/bitbang.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/bitbang.c@3... PS2, Line 32: size_t stdded
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/bitbang.c@4... PS2, Line 45: uint8_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/spi_flash_i... File src/drivers/spi/spi_flash_internal.h:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/spi_flash_i... PS2, Line 31: u8 stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/spi_flash_i... PS2, Line 38: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/spi_sdcard.... File src/drivers/spi/spi_sdcard.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/spi_sdcard.... PS2, Line 364: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/sst.c File src/drivers/spi/sst.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/sst.c@146 PS2, Line 146: u32 stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/sst.c@149 PS2, Line 149: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/tpm/tis.c File src/drivers/spi/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/tpm/tis.c@1... PS2, Line 13: uint16_t stdint
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/tpm/tis.c@8... PS2, Line 81: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/tpm/tpm.c File src/drivers/spi/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/tpm/tpm.c@1... PS2, Line 103: size_t stddef
https://review.coreboot.org/c/coreboot/+/43968/2/src/drivers/spi/tpm/tpm.c@1... PS2, Line 106: uint8_t stdint