Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58155 )
Change subject: drivers/pc80/tpm: Fix wrong debug message ......................................................................
drivers/pc80/tpm: Fix wrong debug message
There is the wrong register offset printed in the debug log when the data register is written:
'lpc_tpm: Write reg 0x18 with 0xnn' should be 'lpc_tpm: Write reg 0x24 with 0xnn' for data FIFO access.
This can be confusing when searching for issues with the help of the TPM debug messages since the code itself is correct. Fix this error.
Change-Id: Ic28ee5a07146e804574b887ea05c62e7e88e9078 Signed-off-by: Werner Zeh werner.zeh@siemens.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/58155 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@mailbox.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/drivers/pc80/tpm/tis.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/drivers/pc80/tpm/tis.c b/src/drivers/pc80/tpm/tis.c index 526b574..2b29acf 100644 --- a/src/drivers/pc80/tpm/tis.c +++ b/src/drivers/pc80/tpm/tis.c @@ -172,7 +172,7 @@
static inline void tpm_write_data(u8 data, int locality) { - TPM_DEBUG_IO_WRITE(TIS_REG_STS, data); + TPM_DEBUG_IO_WRITE(TIS_REG_DATA_FIFO, data); write8(TIS_REG(locality, TIS_REG_DATA_FIFO), data); }