Attention is currently required from: Arthur Heymans, Nicholas Sudsgaard, Paul Menzel.
Hello Arthur Heymans, Michael Niewöhner, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80727?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed: Code-Review+1 by Paul Menzel, Code-Review+2 by Arthur Heymans, Verified+1 by build bot (Jenkins)
Change subject: include/device/azalia_device.h: Correct location2 shift to 28 bits ......................................................................
include/device/azalia_device.h: Correct location2 shift to 28 bits
The location is specified to be in range of 29:24, which is further divided into upper bits (location2) [5:4] and lower bits (location1) [3:0].
Intel High Definition Audio Specification, rev. 1.0a, page 178, Figure 74. Configuration Data Structure.
TEST=Timeless build using AZALIA_PIN_DESC() and without now produce the same binary.
Change-Id: Ia5a3431b70783cb88e866d0fd8ea5530100f3d52 Signed-off-by: Nicholas Sudsgaard devel+coreboot@nsudsgaard.com --- M src/include/device/azalia_device.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/80727/3