Attention is currently required from: Felix Held, Jason Glenesk, Matt DeVillier, Raul Rangel.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76077?usp=email )
Change subject: soc/amd/common/block/acpi/ivrs: use memset on ivhd_[11,40]
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/soc/amd/common/block/acpi/ivrs.c:
https://review.coreboot.org/c/coreboot/+/76077/comment/90aff987_5ee2fae2 :
PS1, Line 206: memset(ivhd_40, 0, sizeof(acpi_ivrs_ivhd40_t));
in other patches in this chain, you're using the `sizeof(*var_name)` format - any reason for using ` […]
fixed in the next patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76077?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70b12fee99d6c71318189ac35e615589a4c8c629
Gerrit-Change-Number: 76077
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 23 Jun 2023 17:44:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-MessageType: comment