Attention is currently required from: Lorenzo Aloe, Michał Żygowski, Paul Menzel.
Máté Kukri has posted comments on this change by Lorenzo Aloe. ( https://review.coreboot.org/c/coreboot/+/83473?usp=email )
Change subject: src/mainboard/dell/snb_ivb_workstations/: Add variant
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/dell/snb_ivb_workstations/Kconfig:
https://review.coreboot.org/c/coreboot/+/83473/comment/0f27c42f_20753507?usp... :
PS7, Line 41: default "OptiPlex 7010/9010 MT" if BOARD_DELL_OPTIPLEX_9010_MT
7010 series will most likely need separate Kconfigs, because the subsystem IDs and SMBIOS will need […]
Can you not just put 7010/9010 in the SMBIOS? (I did that for the 7020/9020 port).
Also does anything check the subsystem IDs? I think the 9010 IDs are fine to use on both (or tbh would it do any harm to get rid of them?)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83473?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I34b7812c3504a80b5730887f1dfa8bef43513abe
Gerrit-Change-Number: 83473
Gerrit-PatchSet: 7
Gerrit-Owner: Lorenzo Aloe
laloe.2fu42@8shield.net
Gerrit-Reviewer: Máté Kukri
kukri.mate@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lorenzo Aloe
laloe.2fu42@8shield.net
Gerrit-Comment-Date: Tue, 16 Jul 2024 12:19:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com