Attention is currently required from: Felix Singer, Maciej Pijanowski, Michał Kopeć, Michał Żygowski.
Krystian Hebel has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/82672?usp=email )
Change subject: ec/dasharo/ec: add Dasharo features
......................................................................
Patch Set 11:
(2 comments)
File src/ec/dasharo/ec/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/82672/comment/933e04d4_c404e201?usp... :
PS10, Line 95: ^^^^DASH.RSET()
It would, if any of the devices we support had an airplane mode led :| Removed all dead airplane mod […]
Done
File src/ec/dasharo/ec/dasharo_ec.c:
https://review.coreboot.org/c/coreboot/+/82672/comment/7cb3f7be_24c25a73?usp... :
PS10, Line 200: #define SPI_ACCESS_SIZE 252
Changed to `(DASHARO_EC_SIZE - REG_DATA - 2)` and added a comment explaining the `2`
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82672?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5600487afcb0a4b261d9ff85e3b2c73535a23f3d
Gerrit-Change-Number: 82672
Gerrit-PatchSet: 11
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Comment-Date: Wed, 24 Jul 2024 14:03:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Kopeć
michal.kopec@3mdeb.com
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com