Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31837 )
Change subject: drivers/tpm: remove initialization call from Intel FSP2.0
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31837/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31837/2//COMMIT_MSG@14
PS2, Line 14: TPM will be initialized whenever
: verstage is executed, depending on how the device is configured
There is actually one case which would fail with or without this change. […]
I am okay if you want to just add a condition saying that RECOVERY_MRC_CACHE hash is maintained in TPM only if VBOOT_STARTS_IN_BOOTBLOCK. I am not sure if there any actual users of recovery mrc cache and VBOOT_STARTS_IN_ROMSTAGE.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31837
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ba91c275c33245be61041cb592e52f861dbafe6
Gerrit-Change-Number: 31837
Gerrit-PatchSet: 2
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 12 Mar 2019 05:22:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment