Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36599 )
Change subject: arch/riscv: Make the setting of fdt calling argument more explicit
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36599/1/src/arch/riscv/boot.c
File src/arch/riscv/boot.c:
https://review.coreboot.org/c/coreboot/+/36599/1/src/arch/riscv/boot.c@56
PS1, Line 56: }
Actually, just blacklisting needs less assumptions: […]
Check for FIT is probably the smartest option as it's the only place where it is used at the moment and makes it more explicit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36599
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id08a12ad7b72ad539e934a133acf2c4a5bcdf1f9
Gerrit-Change-Number: 36599
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Mon, 04 Nov 2019 14:34:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment