Attention is currently required from: Karthik Ramasubramanian, Paul Menzel, Wentao Qin.
Jian Tong has posted comments on this change by Jian Tong. ( https://review.coreboot.org/c/coreboot/+/83290?usp=email )
Change subject: mb/google/brox/var/lotso: Tune I2C frequency for 400 kHz
......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83290/comment/a91517e0_ee823909?usp... :
PS3, Line 7: Fine tune I2C frequency
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/83290/comment/ce960955_0a1eb4e3?usp... :
PS3, Line 9: I2C0 - 392kHz
please add before/after.
Done
https://review.coreboot.org/c/coreboot/+/83290/comment/0930bda0_0e746771?usp... :
PS3, Line 13: TEST=emerge-brox sys-boot/coreboot
How did you check the new values?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83290?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I985837b1b80e973f148529b446905580c0f95e98
Gerrit-Change-Number: 83290
Gerrit-PatchSet: 5
Gerrit-Owner: Jian Tong
tongjian@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jinfang Mao
maojinfang@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 01 Jul 2024 08:07:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org