Attention is currently required from: Bora Guvendik, Selma Bensaid, Tim Wawrzynczak.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61783 )
Change subject: mb/google/brya: remove the delay from for WWAN _ON method.
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/61783/comment/d9954c93_d316592d
PS1, Line 158: register "reset_delay_ms" = "10"
With un-characterized ramp-up and ramp-down times on these signals, a 10ms delay is probably pretty […]
Yes. I think so, too. In addition, I just dropped entire delay and tested to have more boot time budget for the future. we can go ether way. Please let me know.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61783
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9bc36af6e6c944fcd3de23b7d49640ad9d25642d
Gerrit-Change-Number: 61783
Gerrit-PatchSet: 2
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 10 Feb 2022 22:18:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment