Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43741 )
Change subject: drivers/spi/tpm: Enable long cr50 ready pulses for Tiger Lake systems
......................................................................
Patch Set 22:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43741/21/src/drivers/spi/tpm/tpm.c
File src/drivers/spi/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/43741/21/src/drivers/spi/tpm/tpm.c@...
PS21, Line 439: {
brace can be dropped.
Done. (My previous team had a coding policy of always using braces, not matter what. It took several years to acquire the finger memory to adhere to that. It will probably take several years again, before my fingers stop adding braces all the time.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43741
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If83188fd09fe69c2cda4ce1a8bf5b2efe1ca86da
Gerrit-Change-Number: 43741
Gerrit-PatchSet: 22
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jes Klinke
jbk@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Namyoon Woo
namyoon@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 14 Aug 2020 21:24:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment