Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33396 )
Change subject: util/amdfwtool: Add argument for soft fuse override ......................................................................
Patch Set 1: Code-Review-1
(2 comments)
https://review.coreboot.org/#/c/33396/1/util/amdfwtool/amdfwtool.c File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/#/c/33396/1/util/amdfwtool/amdfwtool.c@458 PS1, Line 458: pspdir->entries[count].addr = 1; Ths makes '-T 0' silently act like '-T 1'. Also I wonder if the default value is really compatible across generations, so maybe this entry should only be injected in the directory when the commandline option is present.
https://review.coreboot.org/#/c/33396/1/util/amdfwtool/amdfwtool.c@530 PS1, Line 530: amd_psp_fw_table[i].other = strtoull(str, &tmp, 16); Assigned but unused tmp, should work with NULL as 2nd parameter.