Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42745 )
Change subject: soc/intel: Configure PAVP at compile-time
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42745/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42745/5//COMMIT_MSG@11
PS5, Line 11:
I don’t know the reason of disabling it either, but please mention it in the commit message. […]
I think that the default can be changed. The option to enable it if one does have use of it would be here.
https://review.coreboot.org/c/coreboot/+/42745/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42745/7//COMMIT_MSG@10
PS7, Line 10: protection
management
How about '"a digital copy protection and digital rights management (DRM)"[1] technology for multimedia content?' I'll copy it to the Kconfig help text as well.
1. https://en.wikipedia.org/wiki/Intel_Graphics_Technology#Intel_Insider
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42745
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2aae741bb30e3be3c64324cd6334778bd271a903
Gerrit-Change-Number: 42745
Gerrit-PatchSet: 7
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 26 Jul 2020 23:19:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment