Attention is currently required from: Angel Pons, Arthur Heymans, Jan Samek.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75037 )
Change subject: soc/intel/apl: Remove set but unused variable
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/apollolake/cse.c:
https://review.coreboot.org/c/coreboot/+/75037/comment/ad94f04a_664d03e0
PS1, Line 171: // fwsts2.data = dump_status(2, PCI_ME_HFSTS2);
Actually, no. This removes printing the raw value of FWSTS2 (see `dump_status()` above). How about: […]
Good catch @Angel Pons. As you pointed, we can remove the fwsts2 variable alone while keeping the function call which logs the FWSTS2 register without using the variable.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75037
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62b7390c2de244cce169550e9b1fa41af738525d
Gerrit-Change-Number: 75037
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Jan Samek
jan.samek@siemens.com
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jan Samek
jan.samek@siemens.com
Gerrit-Comment-Date: Wed, 10 May 2023 17:59:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Comment-In-Reply-To: Jan Samek
jan.samek@siemens.com
Gerrit-MessageType: comment