Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36208 )
Change subject: security/vboot: Add vboot callbacks to support EC software sync ......................................................................
Patch Set 8:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36208/3/src/security/vboot/ec_sync.... File src/security/vboot/ec_sync.c:
https://review.coreboot.org/c/coreboot/+/36208/3/src/security/vboot/ec_sync.... PS3, Line 14: #include <2ec_sync.h>
Joel would know better but I think you're not supposed to do this (should be chain-included from vb2 […]
Done
https://review.coreboot.org/c/coreboot/+/36208/2/src/security/vboot/sync_ec.... File src/security/vboot/sync_ec.h:
https://review.coreboot.org/c/coreboot/+/36208/2/src/security/vboot/sync_ec.... PS2, Line 23: vboot_sync_ec
Since this will most likely be the only function in this header file, can it be instead added to vbo […]
Done
https://review.coreboot.org/c/coreboot/+/36208/2/src/security/vboot/sync_ec.... File src/security/vboot/sync_ec.c:
https://review.coreboot.org/c/coreboot/+/36208/2/src/security/vboot/sync_ec.... PS2, Line 135: break;
Should we just fall through to allow the mdelay() before calling google_chromeec_get_vboot_hash() ag […]
Done
https://review.coreboot.org/c/coreboot/+/36208/2/src/security/vboot/sync_ec.... PS2, Line 241: rdev_readat
That's just sorta pushing the problem around for SRAM systems... […]
Done