Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36090 )
Change subject: soc/mediatek/mt8183: Force DRAM retraining if hotkey pressed ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36090/5/src/mainboard/google/kukui/... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/36090/5/src/mainboard/google/kukui/... PS5, Line 79: if (recovery_mode && vboot_recovery_mode_memory_retrain()) {
Maybe it would be better to put all this recovery-mode handling stuff directly into the SoC code? I […]
I was considering that vboot stuff is not available on all systems, so we should try to not make SOC logic based on it (even if the functions provide dummy implementations); instead the SOC functions should provide ways to control the logic properly (for example should we do fast k or full k) and then let board use it own way overriding that (where vboot is the right choice for chrome devices, and other device may have their own preference)
But considering we also don't see that need now, and if more people feeling have these stuff directly in SOC folder is also making lots of sense, I'm fine with changing the design.