Attention is currently required from: Tongtong Pan.
Paul Menzel has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/83790?usp=email )
Change subject: mb/google/dedede:Add fw_config control to wifi driver BUG=b:351968527
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83790/comment/c2b8e6d5_f0407646?usp... :
PS1, Line 7: mb/google/dedede:Add fw_config control to wifi driver
Please add a space after the prefix.
https://review.coreboot.org/c/coreboot/+/83790/comment/e2f0653d_43555c0d?usp... :
PS1, Line 8: BUG=b:351968527
Please add a blank line above.
https://cbea.ms/git-commit/
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83790?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4c7e2fb6fe38c048f29cb8255c4b125ea284de5b
Gerrit-Change-Number: 83790
Gerrit-PatchSet: 1
Gerrit-Owner: Tongtong Pan
pantongtong@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tongtong Pan
pantongtong@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Wed, 07 Aug 2024 06:13:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No