Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31682 )
Change subject: driver/intel/ish: add ish chip driver support ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/31682/1/src/drivers/intel/ish/Kconfig File src/drivers/intel/ish/Kconfig:
https://review.coreboot.org/#/c/31682/1/src/drivers/intel/ish/Kconfig@2 PS1, Line 2: bool "Support Intel ISH driver that publishes _DSD information"
When there is a quoted string after the Kconfig type this option shows up in the Kconfig gui. […]
Done
https://review.coreboot.org/#/c/31682/1/src/drivers/intel/ish/Kconfig@3 PS1, Line 3: depends on ARCH_X86
Should I remove it? I just saw another driver add this. […]
Done
https://review.coreboot.org/#/c/31682/1/src/drivers/intel/ish/ish.c File src/drivers/intel/ish/ish.c:
https://review.coreboot.org/#/c/31682/1/src/drivers/intel/ish/ish.c@71 PS1, Line 71: static struct device_operations pci_ish_device_ops;
Ya. […]
Changes code to be statically complied for everything instead