Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31887 )
Change subject: vboot: make vboot_working_data available to payload
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31887/1/payloads/libpayload/libc/coreboot.c
File payloads/libpayload/libc/coreboot.c:
https://review.coreboot.org/#/c/31887/1/payloads/libpayload/libc/coreboot.c@...
PS1, Line 93: info->vboot_wd = (void *)(uintptr_t)vbwd->range_start;
I'm starting to wonder if we *should* just pass vb2_shared_data + workbuf only, and use lb_range's r […]
Yeah, actually, I think that sounds like a good solution. Let's try that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31887
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id68f43c282939d9e1b419e927a14fe8baa290d91
Gerrit-Change-Number: 31887
Gerrit-PatchSet: 1
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Randall Spangler
rspangler@google.com
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 13 Mar 2019 22:41:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Gerrit-MessageType: comment