[coreboot-gerrit] Change in coreboot[master]: soc/intel/{cnl,icl}: Always use CAR NEM enhanced by default

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34287 )

Change subject: soc/intel/{cnl,icl}: Always use CAR NEM enhanced by default
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34287/2/src/soc/intel/cannonlake/Kc... 
File src/soc/intel/cannonlake/Kconfig:

https://review.coreboot.org/c/coreboot/+/34287/2/src/soc/intel/cannonlake/Kc... 
PS2, Line 272: 	default USE_CANNONLAKE_CAR_NEM_ENHANCED
> I just made some rough statistics of current occurences: […]

Personally, I think it's a good practice to always set a default.  If an additional option gets added at the top of the choice, that changes the default value unless there's a specific default set.

Also, since there's no way to select a value inside a choice for a board, the only method is  with defaults.
https://doc.coreboot.org/getting_started/kconfig.html#choice

For example, if a board wanted to set USE_CANNONLAKE_FSP_CAR, the only way to do it is in a saved .config file.

If we set: default USE_CANNONLAKE_FSP_CAR if DEFAULT_FSP_CAR, that allows the choice to be set correctly somewhere else.

If we do decide to force a default for every choice, we can easily enforce that with the kconfig lint tool.