Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42882 )
Change subject: documentation: Add documentation for Purism Librem Mini ......................................................................
Patch Set 3: Code-Review+1
(11 comments)
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... File Documentation/mainboard/purism/librem_mini.md:
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... PS3, Line 40: by build by *the* build
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... PS3, Line 69: ### External programming Are there diodes on the flash chip's voltage rail?
Also, maybe mention that the EC has its firmware elsewhere, for the sake of completeness?
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... PS3, Line 74: 2 top cover screws, 4 screws securing the mainboard to the chassis, and 4 screws : securing the heatsink/fan assembly to the mainboard (under the SODIMMs). Make it a list?
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... PS3, Line 76: wifi Wi-Fi
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... PS3, Line 77: wifi Wi-Fi
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... PS3, Line 85: - SATA issues with some devices have been mitigated by limiting the SATA speed to 3Gbps Oh, there are SATA issues?
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... PS3, Line 91: kg Pkg
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... PS3, Line 93: AP Access Point?
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... PS3, Line 98: trailing space
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... PS3, Line 99: Suspend/Resume Prefix with "S3"
https://review.coreboot.org/c/coreboot/+/42882/3/Documentation/mainboard/pur... File Documentation/mainboard/purism/librem_mini.png:
PS3: I'd prefer a picture that shows the flash chip location, preferably with pin 1 clearly visible and marked