Attention is currently required from: Francois Toguo Fotso, Tim Wawrzynczak, Paul Menzel, Patrick Rudolph. Hello build bot (Jenkins), Francois Toguo Fotso, Tim Wawrzynczak, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59951
to look at the new patch set (#4).
Change subject: soc/intel/common: Do not trigger crashlog on all resets by default ......................................................................
soc/intel/common: Do not trigger crashlog on all resets by default
Crashlog has error records and PMC reset records two parts. When we send ipc cmd "PMC_IPC_CMD_ID_CRASHLOG_ON_RESET", PMC reset record is enabled. At each warm/cold/global reset, crashlog would be triggered. The cause of this crash would be "TRIGGER_ON_ALL_RESETS", it is used to catch unknown reset reason. At the same time, we would see [Hardware Error] in the kernel log.
If we default enable TRIGGER_ON_ALL_RESETS, we would have too many false alarm. Now we disable PMC reset records part by default. And we could enable it when we need it for the debug purpose.
The generated bert dump is under /var/spool/crash/, we could check this path to verify this CONFIG disable/enable status.
BUG=b:202737385 TEST=No new bert dump after reset.
Signed-off-by: Curtis Chen curtis.chen@intel.com Change-Id: I3ec4ff3c8a3799156de030f4556fe6ce61305139 --- M src/soc/intel/alderlake/Kconfig M src/soc/intel/common/Kconfig.common M src/soc/intel/common/block/crashlog/crashlog.c M src/soc/intel/tigerlake/Kconfig 4 files changed, 16 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/59951/4